For sale or On sale?
Your choice!
For sale
Exemple : ‘’My house is for sale.’’
The correct preposition to use with "sale" is dependant upon the meaning. Using the preposition "for" means that something is being sold.
On sale
Exemple : ‘’This pair of jeans is on sale.’’
If the preposition "on" is used it means that something has been reduced in price.